Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option enableKeepPartialLinestring to generate anyway partial geometry when missing/invalid nodes are found #121

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

frodrigo
Copy link
Contributor

Add option enableKeepPartialLinestring to postgres to keep invalid or partial geometry.

Nodes may be missing outside of the clipping polygon due to the generation method of the extract. It is the case of the OSM-FR extracts. Node may be missing when updating extracts with diff.

These extracts are used by Osmose-QA tool. And it is a QA tool, lake of geometry may produce false positive. Reports.

@frodrigo frodrigo force-pushed the enableKeepPartialLinestring branch from d730433 to b538347 Compare May 26, 2022 19:16
@brettch
Copy link
Member

brettch commented May 27, 2022

Hi @frodrigo,

I see you've already updated the docs for the following two tasks, thanks!

  • --write-pgsql-dump
  • --write-pgsimp-dump

I think the docs for the following two tasks should also be updated. Can you update those as well?

  • --write-pgsql
  • --write-pgsimp

The --fast-write-pgsimp task isn't in the docs so there's no need to update that one 😄

@frodrigo frodrigo force-pushed the enableKeepPartialLinestring branch from b538347 to 5195fd0 Compare May 29, 2022 15:47
@frodrigo
Copy link
Contributor Author

I think the docs for the following two tasks should also be updated.

Done.

@brettch brettch merged commit 447e5df into openstreetmap:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants